ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alejandro Fernandez <afernan...@hortonworks.com>
Subject Re: Review Request 43830: AMBARI-15127 : Add retry logic for DB Setup during Ranger upgrade step (to handle upgrade with Ranger HA)
Date Wed, 02 Mar 2016 19:32:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43830/#review121700
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
(line 126)
<https://reviews.apache.org/r/43830/#comment183472>

    Why version is this?
    CURRENT, source from RU/EU, destination?



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
(line 135)
<https://reviews.apache.org/r/43830/#comment183473>

    Move this import to the top of the file.



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
(line 151)
<https://reviews.apache.org/r/43830/#comment183474>

    Move this import to the top of the file.



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
(line 61)
<https://reviews.apache.org/r/43830/#comment183476>

    Be aware the params.version may change during upgrade and downgrade differently during
RU and EU.



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (line
173)
<https://reviews.apache.org/r/43830/#comment183479>

    FYI, I don't think UI will show newline characters as <br/>



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml (line
172)
<https://reviews.apache.org/r/43830/#comment183480>

    Change "( greater than 3GB )" to " (greater than 3GB) "


- Alejandro Fernandez


On March 2, 2016, 1:36 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43830/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 1:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev
Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15127
>     https://issues.apache.org/jira/browse/AMBARI-15127
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to apply multiple retries for Ranger DB setup calls to handle concurrent calls to
one DB from 2 different hosts where Ranger Admin is installed.
> This scenario is needed to handle upgrades of HDP in a case when Ranger HA is enabled.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
5bcf6b9 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
72133bc 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
a571686 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
fcceaa6 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
7c7a7c8 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
4ffc8eb 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
47e7a64 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
eca1789 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6dcbcb2 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 5c91764 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
4b5b8d5 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
50a9848 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 8003ee0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f775314 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
b09c84a 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 5bc360e 
> 
> Diff: https://reviews.apache.org/r/43830/diff/
> 
> 
> Testing
> -------
> 
> Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message