ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alejandro Fernandez <afernan...@hortonworks.com>
Subject Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Date Wed, 02 Mar 2016 19:20:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review121692
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/alert_check_zeppelin.py
(line 4)
<https://reviews.apache.org/r/44272/#comment183456>

    Use explicit imports



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
(line 28)
<https://reviews.apache.org/r/44272/#comment183457>

    Use explicit imports



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
(line 34)
<https://reviews.apache.org/r/44272/#comment183458>

    Project uses indentation of 2 spaces.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
(line 50)
<https://reviews.apache.org/r/44272/#comment183459>

    We have a providers to install that will already use yum, apt-get, etc, based on the correct
OS.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
(line 58)
<https://reviews.apache.org/r/44272/#comment183460>

    Can this use the exact version instead of /usr/hdp/current?
    My concern is that during RU/EU it will need to install into a directoy that hasn't been
made current yet.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py
(line 24)
<https://reviews.apache.org/r/44272/#comment183461>

    Use explicit imports



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py
(line 30)
<https://reviews.apache.org/r/44272/#comment183462>

    Simpler to just check for not None.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py
(line 64)
<https://reviews.apache.org/r/44272/#comment183464>

    This should be surrounded with try-except or use "with open() as f"



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py
(line 93)
<https://reviews.apache.org/r/44272/#comment183465>

    Should check for length before getting element at [0]



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/status_params.py
(line 22)
<https://reviews.apache.org/r/44272/#comment183466>

    Use explicit imports


- Alejandro Fernandez


On March 2, 2016, 4:54 p.m., Renjith Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 4:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav
Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15265
>     https://issues.apache.org/jira/browse/AMBARI-15265
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/alerts.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-ambari-config.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/kerberos.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/metainfo.xml PRE-CREATION

>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/alert_check_zeppelin.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/setup_snapshot.sh
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/status_params.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION

>   contrib/views/pom.xml 627552a 
>   contrib/views/zeppelin/pom.xml PRE-CREATION 
>   contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44272/diff/
> 
> 
> Testing
> -------
> 
> - manual testing in vm
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message