ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Levas <rle...@hortonworks.com>
Subject Re: Review Request 44206: NPE thrown when secure cluster is created with Blueprint that includes ACCUMULO
Date Wed, 02 Mar 2016 14:46:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44206/#review121648
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On March 2, 2016, 8:53 a.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44206/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 8:53 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15220
>     https://issues.apache.org/jira/browse/AMBARI-15220
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari server load service properties from stack service definition xml files. These
properties than are stored in a map where the key is the config type of the property (the
xml file that contains the property eg. core-site.xml). There might config types that have
no properties defined at all like ACCUMULO's client.xml thus these one were missed to be loaded.

> The side effect of this behavior is that when a cluster is configured when it's created
using Blueprint and INIT config version was only created for the config types that had properties
defined the others were not persisted into the database. 
> 
> If any of the config types that had no INIT version was updated later than the server
threw a NPE while waiting for the config type to get into TOPOLOGY_RESOLVED state.
> 
> In this particular case no INIT version of "client" config type was saved into the clusterconfig
table for ACCUMULO service. Since this was a secure cluster being created using Blueprint
the kerberos related actions were carried out which updated "client" config type by adding
"kerberos.server.primary": "{{bare_accumulo_principal}}" to it. This led to a NPE in the application.
> 
> 
> Stack initialisation has been modified such as after loading service properties from
stack definition xml files it loads also the the empty config types as well.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
7f911e9 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackTest.java
65f94aa 
> 
> Diff: https://reviews.apache.org/r/44206/diff/
> 
> 
> Testing
> -------
> 
> Manual tests:
> 1. Provision secured cluster using a Blueprint that includes ACCUMULO.
> 2. Provisioned a cluster with ACCUMULO included using the Web UI than enabled kerberos
on the cluster.
> 
> Ambari-server unit tests results:
> Results :
> 
> Tests run: 3897, Failures: 0, Errors: 0, Skipped: 33
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message