ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun aoki <jun.aoki....@gmail.com>
Subject Re: Review Request 44145: Update warning messages for HAWQ and PXF in stack advisor
Date Tue, 01 Mar 2016 22:46:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44145/#review121523
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 99)
<https://reviews.apache.org/r/44145/#comment183245>

    union this instead of "+" just in case there is duplicate?



ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 102)
<https://reviews.apache.org/r/44145/#comment183247>

    Good stuff.


- jun aoki


On Feb. 28, 2016, 12:53 a.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44145/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2016, 12:53 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki,
Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15215
>     https://issues.apache.org/jira/browse/AMBARI-15215
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> *On Assign Masters:*
> HAWQ Master and HAWQ Standby Master cannot be deployed on the same host.
> 
> *On Assign Clients:*
> PXF must be installed on the NameNode, Standby NameNode and all the DataNodes. The following
<n> host(s) do not satisfy the colocation recommendation: <list of hostnames>
> 
> HAWQ Segment must be installed on all the DataNodes. The following <n> host(s)
do not satisfy the colocation recommendation: <list of hostnames>
> 
> *On Configuration Validation:*
> The default Postgres port (5432) on the Ambari Server conflicts with the default HAWQ
Master port. If you are using port 5432 for Postgres, you must either deploy the HAWQ Master
on a different host or configure a different port for the HAWQ Master in the HAWQ Configuration
page.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 0b4e543 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 1968c4b 
> 
> Diff: https://reviews.apache.org/r/44145/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested.
> 
> Added additional unit test and updated existing tests:
> 
> test_createComponentLayoutRecommendations_hawq_1_Host (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is not recommended on a single node cluster ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_co_locate_datanode (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSegment gets recommended on same host group which has DATANODE ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_co_locate_with_namenode_or_datanode (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended on same host group which has NAMENODE or DATANODE ...
ok
> test_getComponentLayoutValidations_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ok
> test_getComponentLayoutValidations_sparkts_no_hive (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is not installed ... ok
> test_getComponentLayoutValidations_sparkts_with_hive (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is installed ... ok
> test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendHAWQConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendHBASEConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendKAFKAConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendRangerConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendTezConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendYARNConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_validateHAWQConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_validateHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_validateHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> 
> ----------------------------------------------------------------------
> Ran 26 tests in 0.137s
> 
> OK
> 
> 
> Thanks,
> 
> Matt
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message