ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun aoki <jun.aoki....@gmail.com>
Subject Re: Review Request 44119: Alerts for PXF component status
Date Tue, 01 Mar 2016 02:10:08 GMT


> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
line 88
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line88>
> >
> >     +1 for using Fail instead of Exception. Some of try-except blocks might be expection
type Fail, not Exception and exception wouldn't be handled propertly.

Actually this script itself is the one who handles it, and it handles Exception, instead of
Fail.


> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
line 121
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line121>
> >
> >     Better to raise Fail.

Same as above


> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
line 127
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line127>
> >
> >     There is JIRA in current trunk, which changed version response to this format:
> >     { "version": "v14"}
> >     https://issues.apache.org/jira/browse/HAWQ-340
> >     
> >     So patch for trunk might be expect new response format.

Yes, the new version is what we certify here. (See also the unit test)


> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py, line 26
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272831#file1272831line26>
> >
> >     Are we using all files which we are importing? If no, I would explicitly import
whatever you need only.

Good point. WIll fix it.


- jun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121376
-----------------------------------------------------------


On Feb. 29, 2016, 11:50 p.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 11:50 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
>     https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> -------
> 
> Manually tested. 
> 
> 
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
> 
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message