Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C6D8B18031 for ; Wed, 10 Feb 2016 23:19:18 +0000 (UTC) Received: (qmail 37834 invoked by uid 500); 10 Feb 2016 23:19:18 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 37738 invoked by uid 500); 10 Feb 2016 23:19:18 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 37640 invoked by uid 99); 10 Feb 2016 23:19:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Feb 2016 23:19:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 38A632C1F5B for ; Wed, 10 Feb 2016 23:19:18 +0000 (UTC) Date: Wed, 10 Feb 2016 23:19:18 +0000 (UTC) From: "Hudson (JIRA)" To: dev@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-14984) Script Alert Parameters With Shell Characters Are Not Properly Escaped MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-14984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141932#comment-15141932 ] Hudson commented on AMBARI-14984: --------------------------------- SUCCESS: Integrated in Ambari-trunk-Commit #4306 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4306/]) AMBARI-14984 - Script Alert Parameters With Shell Characters Are Not (jhurley: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=5e6a5556b2a40435c6d35d7851e88d896350f53d]) * ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java * ambari-server/src/main/java/org/apache/ambari/server/state/services/CachedAlertFlushService.java * ambari-funtest/pom.xml * ambari-project/pom.xml * ambari-server/pom.xml * ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java * ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcherTest.java > Script Alert Parameters With Shell Characters Are Not Properly Escaped > ---------------------------------------------------------------------- > > Key: AMBARI-14984 > URL: https://issues.apache.org/jira/browse/AMBARI-14984 > Project: Ambari > Issue Type: Bug > Components: ambari-server > Affects Versions: 2.1.0 > Reporter: Jonathan Hurley > Assignee: Jonathan Hurley > Fix For: 2.4.0 > > Attachments: AMBARI-14984.patch > > > When creating a script alert, the parameters passed to that script should not have any un-escaped special characters. Things like quotes can cause the arguments to be cut: > Original text passed in: > {code} > Metastore on c6403.ambari.apache.org failed "this is in quotes" > {code} > {code} > ===============START================ > Tue Feb 9 16:10:17 EST 2016 > -> Argument: hive_metastore_process > -> Argument: Hive Metastore Process > -> Argument: HIVE > -> Argument: CRITICAL > -> Argument: Metastore on c6403.ambari.apache.org failed > -> Argument: this is in quotes > ================END================= > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)