Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7AFAC18CCB for ; Thu, 11 Feb 2016 05:48:18 +0000 (UTC) Received: (qmail 32395 invoked by uid 500); 11 Feb 2016 05:48:18 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 32346 invoked by uid 500); 11 Feb 2016 05:48:18 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 32312 invoked by uid 99); 11 Feb 2016 05:48:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2016 05:48:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 177CB2C14F0 for ; Thu, 11 Feb 2016 05:48:18 +0000 (UTC) Date: Thu, 11 Feb 2016 05:48:18 +0000 (UTC) From: "Masahiro TANAKA (JIRA)" To: dev@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-14945) Some options have not been applied on Ambari Metrics Collector MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142275#comment-15142275 ] Masahiro TANAKA commented on AMBARI-14945: ------------------------------------------ Understood! Thank you for additional explanation. Personally I prefer putting both variable ( AMS_COLLECTOR_OPTS and AMS_COLLECTOR_GC_OPTS) separetely, but I think that refactoring doesn't fix this problem directly. I would like to discuss the refactoring after this problem is fixed. If you are OK, I'll create another issue on JIRA about the refactoring. Other products, like HBase, concatenate -XX options and -D options [here|https://github.com/apache/ambari/blob/branch-2.1.2/ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/hbase-env.xml#L92]. > Some options have not been applied on Ambari Metrics Collector > -------------------------------------------------------------- > > Key: AMBARI-14945 > URL: https://issues.apache.org/jira/browse/AMBARI-14945 > Project: Ambari > Issue Type: Bug > Components: ambari-metrics > Affects Versions: 2.2.0 > Environment: CentOS 6.4 > Reporter: Masahiro TANAKA > Labels: patch > Attachments: AMBARI-14945.patch > > > Ambari Metrics Collector's jinfo is as below: > {noformat} > [root@c6403 ~]# sudo -u ams /usr/jdk64/jdk1.8.0_60/bin/jinfo 18535 > Attaching to process ID 18535, please wait... > Debugger attached successfully. > Server compiler detected. > JVM version is 25.60-b23 > Java System Properties: > proc_timelineserver = > java.runtime.name = Java(TM) SE Runtime Environment > java.vm.version = 25.60-b23 > sun.boot.library.path = /usr/jdk64/jdk1.8.0_60/jre/lib/amd64 > java.vendor.url = http://java.oracle.com/ > java.vm.vendor = Oracle Corporation > path.separator = : > file.encoding.pkg = sun.io > java.vm.name = Java HotSpot(TM) 64-Bit Server VM > sun.os.patch.level = unknown > sun.java.launcher = SUN_STANDARD > user.country = US > user.dir = /home/ams > java.vm.specification.name = Java Virtual Machine Specification > java.runtime.version = 1.8.0_60-b27 > java.awt.graphicsenv = sun.awt.X11GraphicsEnvironment > os.arch = amd64 > java.endorsed.dirs = /usr/jdk64/jdk1.8.0_60/jre/lib/endorsed > line.separator = > java.io.tmpdir = /tmp > java.vm.specification.vendor = Oracle Corporation > os.name = Linux > sun.jnu.encoding = UTF-8 > java.library.path = /usr/lib/ams-hbase/lib/hadoop-native -XX:+UseConcMarkSweepGC -verbose:gc -XX:+PrintGCDetails -XX:+PrintGCDateStamps -Xloggc:/var/log/ambari-metrics-collector/collector-gc.log-201602051642 > java.specification.name = Java Platform API Specification > java.class.version = 52.0 > java.net.preferIPv4Stack = true > sun.management.compiler = HotSpot 64-Bit Tiered Compilers > os.version = 2.6.32-358.el6.x86_64 > ... > {noformat} > It looks like {{AMS_COLLECTOR_GC_OPTS}} ( which is defined in ams-env.xml ) is interpreted as {{java.library.path}}. > This is caused by an initialization script {{/usr/sbin/ambari-metrics-collector}}. > {{AMS_COLLECTOR_OPTS}} should not be double-quoted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)