Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BBE8182BC for ; Wed, 3 Feb 2016 05:55:45 +0000 (UTC) Received: (qmail 95003 invoked by uid 500); 3 Feb 2016 05:55:40 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 94951 invoked by uid 500); 3 Feb 2016 05:55:40 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 94917 invoked by uid 99); 3 Feb 2016 05:55:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2016 05:55:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CE67C2C14F0 for ; Wed, 3 Feb 2016 05:55:39 +0000 (UTC) Date: Wed, 3 Feb 2016 05:55:39 +0000 (UTC) From: "Hudson (JIRA)" To: dev@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-14882) AMS aggregates Counter values as average over the timeseries (and other issues) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129847#comment-15129847 ] Hudson commented on AMBARI-14882: --------------------------------- FAILURE: Integrated in Ambari-branch-2.2 #283 (See [https://builds.apache.org/job/Ambari-branch-2.2/283/]) AMBARI-14882. AMS aggregates Counter values as average over the (swagle: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=17afb926f7b262ef7a978dc020a718329fc01900]) * ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java * ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java * ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java * ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java * ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java * ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java * ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/Function.java * ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java * ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java * ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java * ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java * ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java * ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java * ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java * ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetricMetadata.java * ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/FunctionTest.java > AMS aggregates Counter values as average over the timeseries (and other issues) > ------------------------------------------------------------------------------- > > Key: AMBARI-14882 > URL: https://issues.apache.org/jira/browse/AMBARI-14882 > Project: Ambari > Issue Type: Task > Components: ambari-metrics > Affects Versions: 2.0.0 > Reporter: Siddharth Wagle > Assignee: Siddharth Wagle > Priority: Critical > Fix For: 2.2.2 > > Attachments: AMBARI-14882.patch > > > Current behavior: > We store the difference between two points if the metric is a counter without dividing by the time difference (Assumes fixed sampling frequency, 10 seconds for Hadoop daemons). This is similar to the Ganglia sink implementation. > Expected behavior: > - Store raw data with type = COUNTER and provide aggregate function called ._rate to calculate rate on demand. > - We need to make sure type attribute on the METRIC_RECORD data capture COUNTER / GAUGE. The HadoopMetricsSink needs to change to send this value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)