Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EA1318697 for ; Mon, 29 Feb 2016 19:32:34 +0000 (UTC) Received: (qmail 12184 invoked by uid 500); 29 Feb 2016 19:32:28 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 12144 invoked by uid 500); 29 Feb 2016 19:32:28 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 12129 invoked by uid 99); 29 Feb 2016 19:32:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Feb 2016 19:32:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0A9052E710F; Mon, 29 Feb 2016 19:32:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1996961147405711735==" MIME-Version: 1.0 Subject: Re: Review Request 43355: Tez Ambari View: Add protocol configuration for YARN From: Alejandro Fernandez To: Pallav Kulshreshtha , DIPAYAN BHOWMICK Cc: Sreenath Somarajapuram , Alejandro Fernandez , Ambari Date: Mon, 29 Feb 2016 19:32:27 -0000 Message-ID: <20160229193227.6191.46949@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alejandro Fernandez X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43355/ X-Sender: Alejandro Fernandez References: <20160209102119.24149.70361@reviews.apache.org> In-Reply-To: <20160209102119.24149.70361@reviews.apache.org> Reply-To: Alejandro Fernandez X-ReviewRequest-Repository: ambari --===============1996961147405711735== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43355/#review121305 ----------------------------------------------------------- contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java (line 277) What if the value is null. - Alejandro Fernandez On Feb. 9, 2016, 10:21 a.m., Sreenath Somarajapuram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43355/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 10:21 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha. > > > Bugs: AMBARI-14951 > https://issues.apache.org/jira/browse/AMBARI-14951 > > > Repository: ambari > > > Description > ------- > > - Value set in yarn.http.policy is required for creating task attempt log links, and we need a mechanism to get that configuration value at the UI side. > - As host points to Ambari proxy, there is no way to know the protocol at which yarn daemons are configured to run. > > > Diffs > ----- > > contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 16b470a > contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java c1456bc > contrib/views/tez/src/main/resources/ui/scripts/init-ambari-view.js c246536 > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java 8a50012 > > Diff: https://reviews.apache.org/r/43355/diff/ > > > Testing > ------- > > Tested locally on Ambari with latest Tez UI 1. > > > Thanks, > > Sreenath Somarajapuram > > --===============1996961147405711735==--