Return-Path: 
 <dev-return-109471-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4F17718264
	for <apmail-ambari-dev-archive@www.apache.org>;
 Fri, 26 Feb 2016 22:28:59 +0000 (UTC)
Received: (qmail 12920 invoked by uid 500); 26 Feb 2016 22:28:59 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 12886 invoked by uid 500); 26 Feb 2016 22:28:59 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 12872 invoked by uid 99); 26 Feb 2016 22:28:58 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Feb 2016 22:28:58 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 998852E6B64;
	Fri, 26 Feb 2016 22:28:58 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============4469761656028660009=="
MIME-Version: 1.0
Subject: Re: Review Request 43944: AMBARI-15132 <condition> in upgrade.xml to
 support set/replace/transfer
From: Di Li <dili@ca.ibm.com>
To: Alejandro Fernandez <afernandez@hortonworks.com>,
 Nate Cole <ncole@hortonworks.com>
Cc: Di Li <dili@ca.ibm.com>, Ambari <dev@ambari.apache.org>
Date: Fri, 26 Feb 2016 22:28:58 -0000
Message-ID: <20160226222858.28813.78205@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: Di Li <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/43944/
X-Sender: Di Li <noreply@reviews.apache.org>
References: <20160226214700.1669.10475@reviews.apache.org>
In-Reply-To: <20160226214700.1669.10475@reviews.apache.org>
Reply-To: Di Li <dili@ca.ibm.com>
X-ReviewRequest-Repository: ambari

--===============4469761656028660009==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43944/
-----------------------------------------------------------

(Updated Feb. 26, 2016, 10:28 p.m.)


Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-15132
    https://issues.apache.org/jira/browse/AMBARI-15132


Repository: ambari


Description
-------

<condition> in upgrade.xml currently only supports single property set. this is to improve it to to support set/replace/transfer. The code change must be backward compatible in order to not break the existing update-**.xml and nonrolling-upgrade-**.xml.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java e77cf36 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java a4dff2e 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 6b22f58 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java ce87668 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 1a5d4e7 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml f345d12 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 237da77 

Diff: https://reviews.apache.org/r/43944/diff/


Testing
-------

unit test
ran upgrade from Ambari 2.2 to Ambari trunk.


Thanks,

Di Li


--===============4469761656028660009==--