Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65E7E18A20 for ; Fri, 26 Feb 2016 16:23:41 +0000 (UTC) Received: (qmail 65403 invoked by uid 500); 26 Feb 2016 16:23:41 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 65370 invoked by uid 500); 26 Feb 2016 16:23:41 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 65354 invoked by uid 99); 26 Feb 2016 16:23:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Feb 2016 16:23:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AE91B2E6A1C; Fri, 26 Feb 2016 16:23:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8570701282885927049==" MIME-Version: 1.0 Subject: Re: Review Request 44066: Add pre-upgrade check that warns about components with VERSION_MISMATCH From: Nate Cole To: Jonathan Hurley , Nate Cole Cc: Dmitro Lisnichenko , Ambari Date: Fri, 26 Feb 2016 16:23:40 -0000 Message-ID: <20160226162340.1671.32318@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Nate Cole X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44066/ X-Sender: Nate Cole X-ReviewBoard-ShipIt: 1 References: <20160226153035.1669.65960@reviews.apache.org> In-Reply-To: <20160226153035.1669.65960@reviews.apache.org> X-ReviewBoard-Diff-For: ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java X-ReviewBoard-Diff-For: ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java Reply-To: Nate Cole X-ReviewRequest-Repository: ambari --===============8570701282885927049== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44066/#review120876 ----------------------------------------------------------- Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java (line 65) FailedOn should be a hostname. The fail message should contain the detail. - Nate Cole On Feb. 26, 2016, 10:30 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44066/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 10:30 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-15203 > https://issues.apache.org/jira/browse/AMBARI-15203 > > > Repository: ambari > > > Description > ------- > > Add pre-upgrade check that warns about components with VERSION_MISMATCH > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa > ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1 > ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java PRE-CREATION > ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/44066/diff/ > > > Testing > ------- > > Failed tests: > ComponentResourceProviderTest.testGetResourcesAsAdministrator:183->testGetResources:289 expected:<[tru]e> but was:<[fals]e> > ComponentResourceProviderTest.testGetResourcesAsClusterAdministrator:188->testGetResources:289 expected:<[tru]e> but was:<[fals]e> > ComponentResourceProviderTest.testGetResourcesAsServiceAdministrator:193->testGetResources:289 expected:<[tru]e> but was:<[fals]e> > AmbariLdapDataPopulatorTest.testSynchronizeExistingLdapGroups_removeDuringIteration:325 > Expectation failure on verify: > AmbariLdapDataPopulatorTestInstance.getLdapGroupByMemberAttr("group2"): expected: 1, actual: 0 > Tests in error: > KerberosCheckerTest.testCheckFailed » Unexpected exception, expected KerberosCheckerTest.testCheckPassed:62 » ClassCast class sun.security.provider... > > Tests run: 3869, Failures: 4, Errors: 2, Skipped: 32 > > [INFO] ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [2.845s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.856s] > [INFO] Ambari Server ..................................... FAILURE [1:34:28.716s] > [INFO] Ambari Agent ...................................... SKIPPED > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > > --===============8570701282885927049==--