Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============4175308947265856505=="
MIME-Version: 1.0
Subject: Re: Review Request 44055: Hide Custom configuration category for
 files which does not support custom configuration in HAWQ and PXF
From: bhuvnesh chaudhary <bchaudhary@pivotal.io>
To: jun aoki <jun.aoki.dev@gmail.com>, Jaimin Jetly <jaimin@hortonworks.com>,
 Richard Zang <rzang@hortonworks.com>,
 Alejandro Fernandez <afernandez@hortonworks.com>,
 Jayush Luniya <jluniya@hortonworks.com>,
 Oleksandr Diachenko <odiachenko@hortonworks.com>,
 Yusaku Sako <yusaku@hortonworks.com>
Cc: bhuvnesh chaudhary <bchaudhary@pivotal.io>, Matt <mithmatt@gmail.com>,
 Ambari <dev@ambari.apache.org>
Date: Fri, 26 Feb 2016 06:14:21 -0000
Message-ID: <20160226061421.28813.69306@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: bhuvnesh chaudhary <noreply@reviews.apache.org>
References: <20160226052606.28813.13548@reviews.apache.org>
In-Reply-To: <20160226052606.28813.13548@reviews.apache.org>
Reply-To: bhuvnesh chaudhary <bchaudhary@pivotal.io>

--===============4175308947265856505==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 26, 2016, 5:26 a.m., Matt wrote:
> > ambari-web/app/models/stack_service.js, line 402
> > <https://reviews.apache.org/r/44055/diff/1/?file=1271824#file1271824line402>
> >
> >     May I know why the pxf config filenames ended up here, but the HAWQ config files have an additional attribute (as in trunk)?
> >     
> >     Curious why it worked for HAWQ but not PXF...
> 
> bhuvnesh chaudhary wrote:
>     Good point. PXF does not have -env at the end of the files added up here. 
>     And this logic automatically takes care of files ending with -env, so we don't need supports_adding_forbidden for them in the *xml.

And this logic automatically takes care of files ending with -env, so we don't need supports_adding_forbidden for HAWQ *-env.xml, removed.


- bhuvnesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/#review120830
-----------------------------------------------------------


On Feb. 26, 2016, 6:11 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44055/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15175
>     https://issues.apache.org/jira/browse/AMBARI-15175
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This minor patch hides custom configuration category for files which does not support custom configuration in HAWQ and PXF
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/models/stack_service.js d9edf6e 
> 
> Diff: https://reviews.apache.org/r/44055/diff/
> 
> 
> Testing
> -------
> 
> yes. manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


--===============4175308947265856505==--