Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3410259467335555500=="
MIME-Version: 1.0
Subject: Re: Review Request 44006: column "upgrade_id" does not exist
 upgrading to Ambari 2.4.0
From: Nate Cole <ncole@hortonworks.com>
To: Jonathan Hurley <jhurley@hortonworks.com>,
 Nate Cole <ncole@hortonworks.com>
Cc: Dmitro Lisnichenko <dlysnichenko@hortonworks.com>,
 Ambari <dev@ambari.apache.org>
Date: Thu, 25 Feb 2016 15:42:25 -0000
Message-ID: <20160225154225.1669.26572@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Nate Cole <noreply@reviews.apache.org>
References: <20160225153706.28813.86099@reviews.apache.org>
In-Reply-To: <20160225153706.28813.86099@reviews.apache.org>
Reply-To: Nate Cole <ncole@hortonworks.com>

--===============3410259467335555500==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44006/#review120711
-----------------------------------------------------------


ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java (lines 583 - 586)
<https://reviews.apache.org/r/44006/#comment182170>

    I think you misunderstood my comment.  You have to add desired_version for servicecomponentdesiredstate in this method.  The upgrade_id column can go where it was


- Nate Cole


On Feb. 25, 2016, 10:37 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44006/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 10:37 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-15183
>     https://issues.apache.org/jira/browse/AMBARI-15183
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> While upgrading the Ambari DB to version 2.4.0 after executing {{ambari-server upgrade}}, the following error is encountered
> 
> {noformat}
> 24 Feb 2016 21:53:56,848 ERROR [main] AmbariJpaLocalTxnInterceptor:114 - [DETAILED ERROR] Rollback reason:
> Local Exception Stack:
> Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
> Internal Exception: org.postgresql.util.PSQLException: ERROR: column "upgrade_id" does not exist
> Position: 137
> Error Code: 0
> Call: SELECT cluster_id, cluster_info, cluster_name, desired_cluster_state, provisioning_state, security_type, desired_stack_id, resource_id, upgrade_id FROM clusters
> Query: ReadAllQuery(name="allClusters" referenceClass=ClusterEntity sql="SELECT cluster_id, cluster_info, cluster_name, desired_cluster_state, provisioning_state, security_type, desired_stack_id, resource_id, upgrade_id FROM clusters")
> at org.eclipse.persistence.exceptions.DatabaseException.sqlException(DatabaseException.java:340)
> at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:682)
> at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeCall(DatabaseAccessor.java:558)
> at org.eclipse.persistence.internal.sessions.AbstractSession.basicExecuteCall(AbstractSession.java:2002)
> at org.eclipse.persistence.sessions.server.ServerSession.executeCall(ServerSession.java:570)
> at org.eclipse.persistence.internal.queries.DatasourceCallQueryMechanism.executeCall(DatasourceCallQueryMechanism.java:242)
> at org.eclipse.persistence.internal.queries.DatasourceCallQueryMechanism.executeCall(DatasourceCallQueryMechanism.java:228)
> at org.eclipse.persistence.internal.queries.DatasourceCallQueryMechanism.executeSelectCall(DatasourceCallQueryMechanism.java:299)
> at org.eclipse.persistence.internal.queries.DatasourceCallQueryMechanism.selectAllRows(DatasourceCallQueryMechanism.java:694)
> at org.eclipse.persistence.internal.queries.ExpressionQueryMechanism.selectAllRowsFromTable(ExpressionQueryMechanism.java:2738)
> at org.eclipse.persistence.internal.queries.ExpressionQueryMechanism.selectAllRows(ExpressionQueryMechanism.java:2691)
> at org.eclipse.persistence.queries.ReadAllQuery.executeObjectLevelReadQuery(ReadAllQuery.java:495)
> at org.eclipse.persistence.queries.ObjectLevelReadQuery.executeDatabaseQuery(ObjectLevelReadQuery.java:1168)
> at org.eclipse.persistence.queries.DatabaseQuery.execute(DatabaseQuery.java:899)
> at org.eclipse.persistence.queries.ObjectLevelReadQuery.execute(ObjectLevelReadQuery.java:1127)
> at org.eclipse.persistence.queries.ReadAllQuery.execute(ReadAllQuery.java:403)
> at org.eclipse.persistence.queries.ObjectLevelReadQuery.executeInUnitOfWork(ObjectLevelReadQuery.java:1215)
> at org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.internalExecuteQuery(UnitOfWorkImpl.java:2896)
> at org.eclipse.persistence.internal.sessions.AbstractSession.executeQuery(AbstractSession.java:1804)
> at org.eclipse.persistence.internal.sessions.AbstractSession.executeQuery(AbstractSession.java:1786)
> at org.eclipse.persistence.internal.sessions.AbstractSession.executeQuery(AbstractSession.java:1751)
> at org.eclipse.persistence.internal.jpa.QueryImpl.executeReadQuery(QueryImpl.java:258)
> at org.eclipse.persistence.internal.jpa.QueryImpl.getResultList(QueryImpl.java:469)
> at org.apache.ambari.server.orm.dao.ClusterDAO.findAll(ClusterDAO.java:92)
> at org.apache.ambari.server.orm.AmbariLocalSessionInterceptor.invoke(AmbariLocalSessionInterceptor.java:53)
> at org.apache.ambari.server.state.cluster.ClustersImpl.loadClustersAndHosts(ClustersImpl.java:198)
> at org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:68)
> at org.apache.ambari.server.state.cluster.ClustersImpl.checkLoaded(ClustersImpl.java:187)
> at org.apache.ambari.server.state.cluster.ClustersImpl.getClusters(ClustersImpl.java:622)
> at org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.addNewConfigurationsFromXml(AbstractUpgradeCatalog.java:300)
> at org.apache.ambari.server.upgrade.UpgradeCatalog240.executeDMLUpdates(UpgradeCatalog240.java:146)
> at org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeData(AbstractUpgradeCatalog.java:659)
> at org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:230)
> at org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:307)
> Caused by: org.postgresql.util.PSQLException: ERROR: column "upgrade_id" does not exist
> Position: 137
> at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
> at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
> at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
> at org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
> at org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:417)
> at org.postgresql.jdbc2.AbstractJdbc2Statement.executeQuery(AbstractJdbc2Statement.java:302)
> at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeSelect(DatabaseAccessor.java:1007)
> at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:642)
> ... 32 more
> {noformat}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java f2055a6 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java f5fafbc 
> 
> Diff: https://reviews.apache.org/r/44006/diff/
> 
> 
> Testing
> -------
> 
> unit tests in progress
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


--===============3410259467335555500==--