Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAE16186FC for ; Wed, 24 Feb 2016 22:11:20 +0000 (UTC) Received: (qmail 85271 invoked by uid 500); 24 Feb 2016 22:11:20 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 85241 invoked by uid 500); 24 Feb 2016 22:11:20 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 85225 invoked by uid 99); 24 Feb 2016 22:11:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Feb 2016 22:11:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2DC1B2A980C; Wed, 24 Feb 2016 22:11:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2696947256513619879==" MIME-Version: 1.0 Subject: Re: Review Request 43965: Move logic involving HBase shell calls to enable normalization and FIFO compaction policy to Java code From: Sumit Mohanty To: Sumit Mohanty , Dmytro Sen , Aravindan Vijayan Cc: Sid Wagle , Ambari Date: Wed, 24 Feb 2016 22:11:20 -0000 Message-ID: <20160224221120.2434.65519@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sumit Mohanty X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43965/ In-Reply-To: <20160224215652.2433.15842@reviews.apache.org> X-Sender: Sumit Mohanty X-ReviewBoard-ShipIt: 1 References: <20160224215652.2433.15842@reviews.apache.org> X-ReviewBoard-Diff-For: ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixConnectionProvider.java X-ReviewBoard-ShipIt-Only: 1 Reply-To: Sumit Mohanty X-ReviewRequest-Repository: ambari --===============2696947256513619879== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43965/#review120588 ----------------------------------------------------------- Ship it! Ship It! - Sumit Mohanty On Feb. 24, 2016, 9:56 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43965/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 9:56 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty. > > > Bugs: AMBARI-15170 > https://issues.apache.org/jira/browse/AMBARI-15170 > > > Repository: ambari > > > Description > ------- > > Currently, HBase shell calls are made through the metrics collector startup script in a parallel thread along with the Collector start jvm, causing performance issues. If the logic is moved to the collector Java code, we can return from the startup script quicker and declare the action to be Success to the agent once schema creating succeeds. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector e319d73 > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java b5ec6e8 > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 1c86ebb > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultPhoenixDataSource.java 8283f7d > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixConnectionProvider.java PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java cd1bfb3 > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java df4fc89 > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 0522f81 > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java 9838bca > > Diff: https://reviews.apache.org/r/43965/diff/ > > > Testing > ------- > > Unit test pass. > Manual test pass. > > > Thanks, > > Sid Wagle > > --===============2696947256513619879==--