Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A49EA189C4 for ; Tue, 23 Feb 2016 01:50:50 +0000 (UTC) Received: (qmail 60140 invoked by uid 500); 23 Feb 2016 01:50:28 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 60106 invoked by uid 500); 23 Feb 2016 01:50:28 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 60090 invoked by uid 99); 23 Feb 2016 01:50:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Feb 2016 01:50:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2CDE91D02EB; Tue, 23 Feb 2016 01:50:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4089420626411065155==" MIME-Version: 1.0 Subject: Re: Review Request 43736: AMBARI-15096 Edit WEB Alert should show Critical for Connection Timeout From: "Zhe \(Joe\) Wang" To: Richard Zang , Srimanth Gunturi , Yusaku Sako Cc: "Zhe \(Joe\) Wang" , Ambari Date: Tue, 23 Feb 2016 01:50:26 -0000 Message-ID: <20160223015026.27513.17849@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zhe \(Joe\) Wang" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43736/ X-Sender: "Zhe \(Joe\) Wang" References: <20160219174821.13179.41477@reviews.apache.org> In-Reply-To: <20160219174821.13179.41477@reviews.apache.org> Reply-To: "Zhe \(Joe\) Wang" X-ReviewRequest-Repository: ambari --===============4089420626411065155== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43736/ ----------------------------------------------------------- (Updated Feb. 23, 2016, 1:50 a.m.) Review request for Ambari, Richard Zang, Srimanth Gunturi, and Yusaku Sako. Bugs: AMBARI-15096 https://issues.apache.org/jira/browse/AMBARI-15096 Repository: ambari Description ------- For WEB alerts, the Connection Timeout fields should show CRITICAL badge since if the connection times out, it is a critical situation. Diffs (updated) ----- ambari-web/app/models/alerts/alert_config.js 839c80d ambari-web/app/templates/main/alerts/configs/alert_config_text_field.hbs 79f1fcb Diff: https://reviews.apache.org/r/43736/diff/ Testing ------- Local ambari-web test passed. 24271 tests complete (21 seconds) 156 tests pending Manual testing done. Thanks, Zhe (Joe) Wang --===============4089420626411065155==--