Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3B1E5183DD for ; Fri, 19 Feb 2016 01:54:31 +0000 (UTC) Received: (qmail 10682 invoked by uid 500); 19 Feb 2016 01:54:31 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 10644 invoked by uid 500); 19 Feb 2016 01:54:31 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 10624 invoked by uid 99); 19 Feb 2016 01:54:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Feb 2016 01:54:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4ED092A6451; Fri, 19 Feb 2016 01:54:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2451591526940072404==" MIME-Version: 1.0 Subject: Re: Review Request 43731: Add Stack Advisor validations for hawq_global_rm_type property in HAWQ From: jun aoki To: jun aoki , Jaimin Jetly , Richard Zang , Alejandro Fernandez , Jayush Luniya , Oleksandr Diachenko , Sumit Mohanty , Yusaku Sako Cc: bhuvnesh chaudhary , Ambari Date: Fri, 19 Feb 2016 01:54:29 -0000 Message-ID: <20160219015429.13178.70267@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: jun aoki X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43731/ X-Sender: jun aoki X-ReviewBoard-ShipIt: 1 References: <20160218192306.13178.47329@reviews.apache.org> In-Reply-To: <20160218192306.13178.47329@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: jun aoki X-ReviewRequest-Repository: ambari --===============2451591526940072404== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43731/#review119771 ----------------------------------------------------------- Ship it! Ship It! - jun aoki On Feb. 18, 2016, 7:23 p.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43731/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 7:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-15083 > https://issues.apache.org/jira/browse/AMBARI-15083 > > > Repository: ambari > > > Description > ------- > > Add Stack Advisor validations for hawq_global_rm_type property in HAWQ. The below 2 cases must be covered: > # 1: If YARN service is not installed, and hawq_global_rm_type is set as yarn, a validation error should be thrown > # 2: If YARN service is installed, and hawq_gloabl_rm_type is set as yarn, no validation error should be thrown > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py b354378 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 545a2b5 > > Diff: https://reviews.apache.org/r/43731/diff/ > > > Testing > ------- > > yes, manual and stack advisor test run. > > > Thanks, > > bhuvnesh chaudhary > > --===============2451591526940072404==--