Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7991205923499875342=="
MIME-Version: 1.0
Subject: Re: Review Request 43727: Patch Upgrade UpgradeCatalog Changes
From: Alejandro Fernandez <afernandez@hortonworks.com>
To: Dmitro Lisnichenko <dlysnichenko@hortonworks.com>,
 Nate Cole <ncole@hortonworks.com>
Cc: Jonathan Hurley <jhurley@hortonworks.com>,
 Alejandro Fernandez <afernandez@hortonworks.com>,
 Ambari <dev@ambari.apache.org>
Date: Thu, 18 Feb 2016 19:52:25 -0000
Message-ID: <20160218195225.13178.78750@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Alejandro Fernandez <noreply@reviews.apache.org>
References: <20160218194414.13178.30836@reviews.apache.org>
In-Reply-To: <20160218194414.13178.30836@reviews.apache.org>
Reply-To: Alejandro Fernandez <afernandez@hortonworks.com>

--===============7991205923499875342==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43727/#review119711
-----------------------------------------------------------


Ship it!


Ship It!

- Alejandro Fernandez


On Feb. 18, 2016, 7:44 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43727/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 7:44 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-15094
>     https://issues.apache.org/jira/browse/AMBARI-15094
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This JIRA will be used to keep track of the changes required for the UpgradeCatalog that will be used for PU.
> 
> +Changed tables+
> {{repo_version}}
> * Add {{type}} column, default 'STANDARD'
> * Add {{version_url}} varchar(1024)
> * Add {{version_xml}} mediumtext/text
> * Add {{version_xsd}} varchar(512)
> * Add {{parent_id}} bigint, nullable
> 
> {{servicecomponentdesiredstate}}
> * Add PK {{id}} column
> * Remove existing PK, create {{UNIQUE}} constraint out of same columns
> * Create {{INDEX}} on old PK columns
> 
> {{hostcomponentdesiredstate}}
> * Reorder {{hstcmpnntdesiredstatecmpnntnme}} {{FOREIGN KEY}}
> ** {{(component_name, service_name, cluster_id)}}
> 
> {{hostcomponentstate}}
> * Reorder {{hstcomponentstatecomponentname}} {{FOREIGN KEY}}
> ** {{(component_name, service_name, cluster_id)}}
> 
> {{servicecomponent_history}}
> * Creation of new table
> * Addition of new sequence to track PK ID
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 49f108b 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java abd05bc 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java d97962f 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5 
> 
> Diff: https://reviews.apache.org/r/43727/diff/
> 
> 
> Testing
> -------
> 
> Upgraded a trunk database to a branch-dev-patch-upgrade database on MySQL and Postgres.
> 
> Unit tests pending...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


--===============7991205923499875342==--