Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 406CE18A9E for ; Thu, 18 Feb 2016 17:42:15 +0000 (UTC) Received: (qmail 32861 invoked by uid 500); 18 Feb 2016 17:42:02 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 32830 invoked by uid 500); 18 Feb 2016 17:42:02 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 32807 invoked by uid 99); 18 Feb 2016 17:42:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Feb 2016 17:42:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A3EE32A6402; Thu, 18 Feb 2016 17:42:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7125137871863451321==" MIME-Version: 1.0 Subject: Re: Review Request 42912: Clients names different on host details page and filter From: Oleg Nechiporenko To: Sebastian Toader , Jaimin Jetly , Robert Nettleton , Sumit Mohanty , Oliver Szabo , Oleg Nechiporenko , Yusaku Sako Cc: Ambari , Daniel Gergely Date: Thu, 18 Feb 2016 17:42:00 -0000 Message-ID: <20160218174200.13179.49928@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Oleg Nechiporenko X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42912/ X-Sender: Oleg Nechiporenko References: <20160218094409.13178.40888@reviews.apache.org> In-Reply-To: <20160218094409.13178.40888@reviews.apache.org> Reply-To: Oleg Nechiporenko X-ReviewRequest-Repository: ambari --===============7125137871863451321== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42912/#review119642 ----------------------------------------------------------- +1 for UI changes. It looks good. - Oleg Nechiporenko On Feb. 18, 2016, 9:44 a.m., Daniel Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42912/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 9:44 a.m.) > > > Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako. > > > Bugs: AMBARI-14830 > https://issues.apache.org/jira/browse/AMBARI-14830 > > > Repository: ambari > > > Description > ------- > > Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout. > Displayed names now come from metainfo.xml > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970 > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java f7dd301 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3ad6e64 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7e1dd1d > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java bfb6214 > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70 > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35 > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1 > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml b5db91b > ambari-server/src/main/resources/properties.json 4052ad2 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java f38fab1 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156 > ambari-web/app/controllers/global/update_controller.js 0a5d913 > ambari-web/app/mappers/components_state_mapper.js 0f2b627 > ambari-web/app/mappers/hosts_mapper.js 7691f2b > ambari-web/app/models/client_component.js 816950c > ambari-web/app/models/host_component.js 77395f2 > > Diff: https://reviews.apache.org/r/42912/diff/ > > > Testing > ------- > > The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix. > > > Thanks, > > Daniel Gergely > > --===============7125137871863451321==--