Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8306179337936165843=="
MIME-Version: 1.0
Subject: Re: Review Request 43683: RU/EU from HDP 2.2 to 2.3 or 2.4 to remove
 deprecated kafka-broker port property
From: Nate Cole <ncole@hortonworks.com>
To: Nate Cole <ncole@hortonworks.com>,
 Jayush Luniya <jluniya@hortonworks.com>,
 Jonathan Hurley <jhurley@hortonworks.com>,
 Dmytro Grinenko <hapy.lestat@gmail.com>,
 Dmitro Lisnichenko <dlysnichenko@hortonworks.com>,
 Sriharsha Chintalapani <harsha@hortonworks.com>
Cc: Alejandro Fernandez <afernandez@hortonworks.com>,
 Ambari <dev@ambari.apache.org>
Date: Wed, 17 Feb 2016 23:55:20 -0000
Message-ID: <20160217235520.13178.51509@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Nate Cole <noreply@reviews.apache.org>
References: <20160217233436.13178.95167@reviews.apache.org>
In-Reply-To: <20160217233436.13178.95167@reviews.apache.org>
Reply-To: Nate Cole <ncole@hortonworks.com>

--===============8306179337936165843==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43683/#review119554
-----------------------------------------------------------


Ship it!


Ship It!

- Nate Cole


On Feb. 17, 2016, 6:34 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43683/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 6:34 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-15033
>     https://issues.apache.org/jira/browse/AMBARI-15033
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> kafka-broker "listeners" property was added in HDP 2.3 with a default value in the stack as "PLAINTEXT://localhost:6667"
> Ambari then replaces the value "localhost" with the hostname it is actually running on. So this is ok.
> The only change needed is for RU/EU from HDP 2.2 to 2.3, 2.2 to 2.4, and 2.3 to 2.4 to remove the deprecated "port" property.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 84da86c 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml c0eae48 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 353dc86 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml cfd2904 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-broker.xml 6e924e2 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml b8963bc 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 4e148d5 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 59f9389 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml ee06577 
> 
> Diff: https://reviews.apache.org/r/43683/diff/
> 
> 
> Testing
> -------
> 
> Verified during RU and EU from HDP 2.2 to 2.3 with several Kafka brokers installed
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


--===============8306179337936165843==--