Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============9166650957271185100=="
MIME-Version: 1.0
Subject: Re: Review Request 43428: Provide explicit ordering for roles
From: Robert Levas <rlevas@hortonworks.com>
To: Jonathan Hurley <jhurley@hortonworks.com>,
 Robert Nettleton <rnettleton@hortonworks.com>,
 Nate Cole <ncole@hortonworks.com>
Cc: Robert Levas <rlevas@hortonworks.com>, Ambari <dev@ambari.apache.org>
Date: Thu, 11 Feb 2016 14:29:17 -0000
Message-ID: <20160211142917.24150.76595@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Robert Levas <noreply@reviews.apache.org>
References: <20160211140747.24149.29710@reviews.apache.org>
In-Reply-To: <20160211140747.24149.29710@reviews.apache.org>
Reply-To: Robert Levas <rlevas@hortonworks.com>

--===============9166650957271185100==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43428/
-----------------------------------------------------------

(Updated Feb. 11, 2016, 9:29 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.


Bugs: AMBARI-14980
    https://issues.apache.org/jira/browse/AMBARI-14980


Repository: ambari


Description
-------

Since it may be desired to order roles in ways other than alphabetically, each role should have an explicit numerical order that may be used by UI's. 

Roles should be explicitly ordered by the amount of access privileges they have. 


Role Name             | Explicit Order Value 
----------------------|----------------------
Ambari Administrator  | 1
Cluster Administrator | 2
Cluster Operator      | 3
Service Administrator | 4
Service Operator      | 5
Cluster User          | 6
View User             | 7


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PermissionResourceProvider.java 640123e 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java a692730 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 3414388 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 0fdfd2b 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 11e43c2 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8d4ba28 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c762ac4 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 81b41fe 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql f8c9b8d 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 324c24d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java 7658c0f 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java d1d68f2 

Diff: https://reviews.apache.org/r/43428/diff/


Testing (updated)
-------

Manualy tested a new install and an upgrade

# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:03:22.906s
[INFO] Finished at: Wed Feb 10 14:03:26 EST 2016
[INFO] Final Memory: 68M/1507M
[INFO] ------------------------------------------------------------------------

# Jenkins test result: 

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:33 h
[INFO] Finished at: 2016-02-11T06:41:22+00:00
[INFO] Final Memory: 132M/464M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


--===============9166650957271185100==--