Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============4574803098758621976=="
MIME-Version: 1.0
Subject: Re: Review Request 43402: assign_master_component.js does not show
 recommendations while adding master component for a service which is
 already installed
From: jun aoki <jun.aoki.dev@gmail.com>
To: jun aoki <jun.aoki.dev@gmail.com>,
 bhuvnesh chaudhary <bchaudhary@pivotal.io>,
 Jaimin Jetly <jaimin@hortonworks.com>, Lav Jain <ljain@pivotal.io>,
 Alejandro Fernandez <afernandez@hortonworks.com>,
 Alexandr Antonenko <hiveww@gmail.com>, Newton Alex <nalex@pivotal.io>,
 Oleksandr Diachenko <odiachenko@hortonworks.com>,
 Alexander Denissov <adenissov@apache.org>,
 Goutam Tadi <goutam.tadi1@gmail.com>,
 Sumit Mohanty <smohanty@hortonworks.com>,
 Aleksandr Kovalenko <akovalenko@hortonworks.com>
Cc: Matt <mithmatt@gmail.com>, Ambari <dev@ambari.apache.org>
Date: Thu, 11 Feb 2016 00:33:25 -0000
Message-ID: <20160211003325.24150.68909@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: jun aoki <noreply@reviews.apache.org>
References: <20160210195845.24149.58668@reviews.apache.org>
In-Reply-To: <20160210195845.24149.58668@reviews.apache.org>
Reply-To: jun aoki <jun.aoki.dev@gmail.com>

--===============4574803098758621976==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/#review118777
-----------------------------------------------------------


ambari-web/app/mixins/wizard/assign_master_components.js (line 678)
<https://reviews.apache.org/r/43402/#comment180090>

    line 680 - 682 of the original is extracted into local variables. Here, and the line 682 of patch is adding a new condition when to show master components. Is it right?


- jun aoki


On Feb. 10, 2016, 7:58 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43402/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 7:58 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14987
>     https://issues.apache.org/jira/browse/AMBARI-14987
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
> 
> This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster). 
> The fix might also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js ecf55f7 
>   ambari-web/app/mixins/wizard/assign_master_components.js 0693507 
>   ambari-web/test/controllers/wizard/step5_test.js a2bc687 
>   ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43402/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested.
> 
> Unit tests passed:
>   24227 tests complete (21 seconds)
>   156 tests pending
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48.026 s
> [INFO] Finished at: 2016-02-10T11:57:57-08:00
> [INFO] Final Memory: 12M/310M
> [INFO] -----------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>


--===============4574803098758621976==--