Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3811253693249111860=="
MIME-Version: 1.0
Subject: Re: Review Request 43266: Config consistency checker
From: Vitalyi Brodetskyi <vbrodetskyi@hortonworks.com>
To: Alejandro Fernandez <afernandez@hortonworks.com>,
 Myroslav Papirkovskyy <mpapyrkovskyy@hortonworks.com>
Cc: Nahappan Somasundaram <nsomasundaram@hortonworks.com>,
 Vitalyi Brodetskyi <vbrodetskyi@hortonworks.com>,
 Ambari <dev@ambari.apache.org>
Date: Wed, 10 Feb 2016 22:42:13 -0000
Message-ID: <20160210224213.24150.3122@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Vitalyi Brodetskyi <noreply@reviews.apache.org>
References: <20160210213922.24150.78871@reviews.apache.org>
In-Reply-To: <20160210213922.24150.78871@reviews.apache.org>
Reply-To: Vitalyi Brodetskyi <vbrodetskyi@hortonworks.com>

--===============3811253693249111860==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


> On Лют. 10, 2016, 9:39 після полудня, Nahappan Somasundaram wrote:
> >

Not sure but i think current check, which i started implementing will be morr complex. We are planning to add check for users/permissions/repo urls/security and etc. To my mind using simple queries is more faster and safe. And my functionality can be called by separate command. In future we can use my code for complex("hard") check which can be called by separate command. In the same time, your check before ambari start will be "light" version of check which will contain only some critical checks.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43266/#review118729
-----------------------------------------------------------


On Лют. 10, 2016, 10:22 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43266/
> -----------------------------------------------------------
> 
> (Updated Лют. 10, 2016, 10:22 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-14948
>     https://issues.apache.org/jira/browse/AMBARI-14948
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Command line utility to find inconsistencies in configs
> Services without configs
> Configs without services
> relationship between clusterconfig, serviceconfigmapping, and clusterconfigmapping
> Do outter joins and find missing configs
> At least one should be selected for config type, compare known config types vs expected in the stack, versions are incremental
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 72d94ed 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java PRE-CREATION 
>   ambari-server/src/main/python/ambari-server.py 8be79a5 
>   ambari-server/src/main/python/ambari_server/checkDatabase.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 686ac9a 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/CheckDatabaseHelperTest.java PRE-CREATION 
>   ambari-server/src/test/python/TestAmbariServer.py fdc375b 
> 
> Diff: https://reviews.apache.org/r/43266/diff/
> 
> 
> Testing
> -------
> 
> Will add tests later
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


--===============3811253693249111860==--