Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56B1E1817E for ; Wed, 10 Feb 2016 19:23:48 +0000 (UTC) Received: (qmail 75354 invoked by uid 500); 10 Feb 2016 19:23:48 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 75321 invoked by uid 500); 10 Feb 2016 19:23:48 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 75303 invoked by uid 99); 10 Feb 2016 19:23:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Feb 2016 19:23:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1E6F929B5A3; Wed, 10 Feb 2016 19:23:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7740275011769505394==" MIME-Version: 1.0 Subject: Re: Review Request 43281: AMBARI-14885: After exporting blueprint from existing cluster knox_master_secret is exported. From: Amruta Borkar To: Di Li , Robert Nettleton Cc: Amruta Borkar , Ambari Date: Wed, 10 Feb 2016 19:23:47 -0000 Message-ID: <20160210192347.24149.92961@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Amruta Borkar X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43281/ X-Sender: Amruta Borkar References: <20160208181518.24149.26533@reviews.apache.org> In-Reply-To: <20160208181518.24149.26533@reviews.apache.org> Reply-To: Amruta Borkar X-ReviewRequest-Repository: ambari --===============7740275011769505394== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43281/ ----------------------------------------------------------- (Updated Feb. 10, 2016, 7:23 p.m.) Review request for Ambari, Di Li and Robert Nettleton. Bugs: AMBARI-14885 https://issues.apache.org/jira/browse/AMBARI-14885 Repository: ambari Description ------- AMBARI-14885: After exporting blueprint from existing cluster knox_master_secret is exported. This causes error while registering the blueprint. Following error occurs while using and exported blueprint if a password or secret property is present in the blueprint: { "status" : 400, "message" : "Blueprint configuration validation failed: Secret references are not allowed in blueprints, replace following properties with real passwords:\n Config:knox-env Property:knox_master_secret\n" } Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java de31a0d ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 7a77a25 Diff: https://reviews.apache.org/r/43281/diff/ Testing ------- In this patch, isPropertyIncluded() method is modified to include the properties marked as secret. Corresponding test cases are also added. The fix excludes properties marked as 'secret' while export blueprint. Test cases are added to test various combination by which a property can be marked as 'secret'. Test cases verify that the properties that do not match the rule "*SECRET" are still included. Thanks, Amruta Borkar --===============7740275011769505394==--