Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8283205508563575071=="
MIME-Version: 1.0
Subject: Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
From: Jonathan Hurley <jhurley@hortonworks.com>
To: Jonathan Hurley <jhurley@hortonworks.com>,
 Dmitro Lisnichenko <dlysnichenko@hortonworks.com>
Cc: Alejandro Fernandez <afernandez@hortonworks.com>,
 Nate Cole <ncole@hortonworks.com>, Ambari <dev@ambari.apache.org>
Date: Wed, 10 Feb 2016 15:50:10 -0000
Message-ID: <20160210155010.24150.26993@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Jonathan Hurley <noreply@reviews.apache.org>
References: <20160210000917.24150.16201@reviews.apache.org>
In-Reply-To: <20160210000917.24150.16201@reviews.apache.org>
Reply-To: Jonathan Hurley <jhurley@hortonworks.com>

--===============8283205508563575071==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 9, 2016, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, line 243
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238815#file1238815line243>
> >
> >     if null or empty, should raise exception.
> 
> Nate Cole wrote:
>     Untrue.  A repo_version without these elements is 1) backwards compatible and 2) can be a STANDARD repository instead of a PATCH one.  In addition, we're checking for the existence of targeted services.  If there are no targeted services, that means ALL services and regular RU/EU should be used.

But the only way you'd get into this block is by having a PARTIAL upgrade pack, no? Doesn't that mean that you have to have an XML file?


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118505
-----------------------------------------------------------


On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 6:01 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-14978
>     https://issues.apache.org/jira/browse/AMBARI-14978
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Created separate upgrade packs for patches.  The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
> 
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43377/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> 
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


--===============8283205508563575071==--