Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3724445272721018295=="
MIME-Version: 1.0
Subject: Re: Review Request 43385: AMBARI-14982 : Change AMS configs to deal
 with slow writes to WASB
From: Sid Wagle <swagle@hortonworks.com>
To: Sid Wagle <swagle@hortonworks.com>,
 Sumit Mohanty <smohanty@hortonworks.com>, Dmytro Sen <dsen@hortonworks.com>
Cc: Aravindan Vijayan <avijayan@hortonworks.com>,
 Ambari <dev@ambari.apache.org>
Date: Wed, 10 Feb 2016 01:11:18 -0000
Message-ID: <20160210011118.24149.47802@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Sid Wagle <noreply@reviews.apache.org>
References: <20160209230412.24150.31060@reviews.apache.org>
In-Reply-To: <20160209230412.24150.31060@reviews.apache.org>
Reply-To: Sid Wagle <swagle@hortonworks.com>

--===============3724445272721018295==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43385/#review118526
-----------------------------------------------------------


ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java (line 1251)
<https://reviews.apache.org/r/43385/#comment179794>

    What if user specfied a value less than a day in seconds.


- Sid Wagle


On Feb. 9, 2016, 11:04 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43385/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 11:04 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14982
>     https://issues.apache.org/jira/browse/AMBARI-14982
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Enhancements in this patch.
> 
> 1. Set precision table TTL to 1day/7days based on embedded/distributed mode.
> 2. Disable TimelineMetricStoreWatcher in distributed mode.
> 3. Change AMS HBase tables TTL config values to DAYS instead of SECONDS.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 5ee8b44 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 71e65f7 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java a1a0c5d 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 7e2683d 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 3391943 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py b4bb68f 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 913b08d 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 904688a 
> 
> Diff: https://reviews.apache.org/r/43385/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done for stack_advisor and TTL units changes.
> 
> ambari-metrics unit tests pass.
> 
> Upgrade Testing in progress.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


--===============3724445272721018295==--