Return-Path: 
 <dev-return-106515-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3DFF018DC6
	for <apmail-ambari-dev-archive@www.apache.org>;
 Tue,  9 Feb 2016 19:06:46 +0000 (UTC)
Received: (qmail 47651 invoked by uid 500); 9 Feb 2016 19:06:46 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 47618 invoked by uid 500); 9 Feb 2016 19:06:46 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 47605 invoked by uid 99); 9 Feb 2016 19:06:45 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Feb 2016 19:06:45 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 158BE29B17D;
	Tue,  9 Feb 2016 19:06:45 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============7397261316746099465=="
MIME-Version: 1.0
Subject: Re: Review Request 43370: AMS cannot be installed on trunk
From: jun aoki <jun.aoki.dev@gmail.com>
To: Aravindan Vijayan <avijayan@hortonworks.com>
Cc: jun aoki <jun.aoki.dev@gmail.com>, Ambari <dev@ambari.apache.org>
Date: Tue, 09 Feb 2016 19:06:45 -0000
Message-ID: <20160209190645.24149.94166@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: jun aoki <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/43370/
X-Sender: jun aoki <noreply@reviews.apache.org>
References: <20160209185712.24149.24073@reviews.apache.org>
In-Reply-To: <20160209185712.24149.24073@reviews.apache.org>
Reply-To: jun aoki <jun.aoki.dev@gmail.com>
X-ReviewRequest-Repository: ambari

--===============7397261316746099465==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43370/#review118434
-----------------------------------------------------------




ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py (line 45)
<https://reviews.apache.org/r/43370/#comment179646>

    I wonder if ambari-common is right place for the conditional logic. We are trying to decouple between service definitions and core part, and this implementation seems to bring a service (grafana) specific logic back in core.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml (line 99)
<https://reviews.apache.org/r/43370/#comment179651>

    Could this be more expandable if it is a full path to a py file + a method name ? the conditional logic is specific to grafana and we can have it in grafana's service defintion (or anywhere you want)
    
    Here is my not-so-sophisticated example
    ```
    <condition>common-servies/AMBARI_METRICS/0.1.0/package/scripts/condition.py#should_install_ams_grafana
    ```


- jun aoki


On Feb. 9, 2016, 6:57 p.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43370/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 6:57 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-14964
>     https://issues.apache.org/jira/browse/AMBARI-14964
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS cannot be installed on trunk
> Creating this review on behalf of  Aravindan Vijayan
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 0fb0fe4 
>   ambari-funtest/src/test/resources/stacks/HDP/2.1.1/services/AMBARI_METRICS/metainfo.xml be99b83 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml c3dbc6b 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py ddefed7 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py d96309c 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py 921bed7 
> 
> Diff: https://reviews.apache.org/r/43370/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> jun aoki
> 
>


--===============7397261316746099465==--