Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D07A517CB6 for ; Mon, 8 Feb 2016 08:20:06 +0000 (UTC) Received: (qmail 24862 invoked by uid 500); 8 Feb 2016 08:20:06 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 24832 invoked by uid 500); 8 Feb 2016 08:20:06 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 24527 invoked by uid 99); 8 Feb 2016 08:20:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Feb 2016 08:20:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CB8971CF921; Mon, 8 Feb 2016 08:20:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4960921992046329399==" MIME-Version: 1.0 Subject: Re: Review Request 43055: AMBARI-14403: Improve Quicklink logic to remove any unnecessary legacy code From: Alexandr Antonenko To: Richard Zang , Alexandr Antonenko , Xi Wang , Jaimin Jetly , Srimanth Gunturi Cc: Di Li , Ambari Date: Mon, 08 Feb 2016 08:20:05 -0000 Message-ID: <20160208082005.24150.8199@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexandr Antonenko X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43055/ In-Reply-To: <20160205144006.1670.50417@reviews.apache.org> X-Sender: Alexandr Antonenko X-ReviewBoard-ShipIt: 1 References: <20160205144006.1670.50417@reviews.apache.org> X-ReviewBoard-Diff-For: ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/quicklinks/quicklinks.json X-ReviewBoard-Diff-For: ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks-mapred/quicklinks.json X-ReviewBoard-Diff-For: ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/quicklinks/quicklinks.json X-ReviewBoard-Diff-For: ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks/quicklinks.json X-ReviewBoard-ShipIt-Only: 1 Reply-To: Alexandr Antonenko X-ReviewRequest-Repository: ambari --===============4960921992046329399== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43055/#review118211 ----------------------------------------------------------- Ship it! Ship It! - Alexandr Antonenko On Feb. 5, 2016, 2:40 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43055/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 2:40 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Richard Zang, Srimanth Gunturi, and Xi Wang. > > > Bugs: AMBARI-14403 > https://issues.apache.org/jira/browse/AMBARI-14403 > > > Repository: ambari > > > Description > ------- > > During the review process of JIRA AMBARI-11268, it was discussed that the quicklink required UI code may use some refactoring to remove unnecessary legacy code. > > use this jira for the work. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java a0890f1 > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/quicklinks/quicklinks.json bbea282 > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/quicklinks/quicklinks.json dd17275 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 194f79e > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/quicklinks/quicklinks.json PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml a5d6862 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/quicklinks/quicklinks.json PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml 8b24091 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/quicklinks/quicklinks.json e7c23a4 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml 7a1c715 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks-mapred/quicklinks.json PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks/quicklinks.json PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/quicklinks/quicklinks.json 7e2ba25 > ambari-server/src/main/resources/stacks/HDP/2.2/services/SPARK/quicklinks/quicklinks.json c3e51e6 > ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/quicklinks/quicklinks.json 21c5e54 > ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json dd67ec0 > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json b52af55 > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json 9fb97d0 > ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json e7c23a4 > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/quicklinks/quicklinks.json 74ea153 > ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/quicklinks/quicklinks.json c3e51e6 > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json 993267d > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json 3cf4c7f > ambari-server/src/test/resources/child_quicklinks_to_merge.json 819c400 > ambari-server/src/test/resources/child_quicklinks_to_override.json b042f98 > ambari-server/src/test/resources/parent_quicklinks.json 3cf4c7f > ambari-web/app/assets/data/configurations/quicklinks.json 505a619 > ambari-web/app/views/common/quick_view_link_view.js c2f7dcc > > Diff: https://reviews.apache.org/r/43055/diff/ > > > Testing > ------- > > unit test > > manually patch a cluster with UI changes and load quick links to make sure I can open external links. > > > Thanks, > > Di Li > > --===============4960921992046329399==--