Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============2324687782076566626=="
MIME-Version: 1.0
Subject: Re: Review Request 43255: Some user-specified auth-to-local rules
 fail to render when auto generating auth-to-local rules
From: Robert Levas <rlevas@hortonworks.com>
To: Jonathan Hurley <jhurley@hortonworks.com>,
 Robert Nettleton <rnettleton@hortonworks.com>,
 Nate Cole <ncole@hortonworks.com>
Cc: Robert Levas <rlevas@hortonworks.com>, Ambari <dev@ambari.apache.org>
Date: Fri, 05 Feb 2016 21:04:13 -0000
Message-ID: <20160205210413.1669.806@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Robert Levas <noreply@reviews.apache.org>
References: <20160205171650.1670.50526@reviews.apache.org>
In-Reply-To: <20160205171650.1670.50526@reviews.apache.org>
Reply-To: Robert Levas <rlevas@hortonworks.com>

--===============2324687782076566626==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 5, 2016, 12:16 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java, lines 125-132
> > <https://reviews.apache.org/r/43255/diff/1/?file=1236209#file1236209line125>
> >
> >     Cloneable/clone()?  Won't hold up review for it :)

Oddly enough, there are no Cloneable classes in the ambari-server src tree.  However I will add change this.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43255/#review118033
-----------------------------------------------------------


On Feb. 5, 2016, 11:38 a.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43255/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 11:38 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-14938
>     https://issues.apache.org/jira/browse/AMBARI-14938
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When processing the user-specified auth-to-local rules while automatically generating auth-to-local rule sets using `org.apache.ambari.server.controller.AuthToLocalBuilder`, some rules fail to render.
> 
> This occurs when escape characters are used in the replacement pattern or replacement string of the rule, where a role looks like:
> 
> ```
> RULE: [n:string](regexp)s/pattern/replacement/[g]
> ```
> 
> To fix this issue, the regular expression used to parse the rules need to be augmented to allow for those characters.
> 
> NOTE: Also did some cleanup of `org.apache.ambari.server.controller.AuthToLocalBuilder`.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java a8fc487 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 556bed8 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AuthToLocalBuilderTest.java 122e632 
> 
> Diff: https://reviews.apache.org/r/43255/diff/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> # Local test results: PASSED
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


--===============2324687782076566626==--