Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2A461183C5 for ; Fri, 5 Feb 2016 16:36:10 +0000 (UTC) Received: (qmail 11212 invoked by uid 500); 5 Feb 2016 16:36:10 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 11175 invoked by uid 500); 5 Feb 2016 16:36:09 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 11156 invoked by uid 99); 5 Feb 2016 16:36:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2016 16:36:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 374C11CC416; Fri, 5 Feb 2016 16:36:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7777551344155261974==" MIME-Version: 1.0 Subject: Re: Review Request 43189: AMBARI-14871: Better messages when Ambari web UI can't resolve hosts to build quicklinks From: Alexandr Antonenko To: Alexandr Antonenko , Jaimin Jetly Cc: Di Li , Ambari Date: Fri, 05 Feb 2016 16:36:09 -0000 Message-ID: <20160205163609.7684.4406@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexandr Antonenko X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43189/ X-Sender: Alexandr Antonenko References: <20160205143931.1669.54673@reviews.apache.org> In-Reply-To: <20160205143931.1669.54673@reviews.apache.org> Reply-To: Alexandr Antonenko X-ReviewRequest-Repository: ambari --===============7777551344155261974== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43189/#review118026 ----------------------------------------------------------- ambari-web/app/views/common/quick_view_link_view.js (line 442) Why are you making a compare with null ? I do not see any posible way oozieHostsArray can get null value - Alexandr Antonenko On Feb. 5, 2016, 2:39 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43189/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 2:39 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Jaimin Jetly. > > > Bugs: AMBARI-14871 > https://issues.apache.org/jira/browse/AMBARI-14871 > > > Repository: ambari > > > Description > ------- > > It currently says "Hostname is undefined". This JIRA is to update the logic a little bit in an attempt to display better error messages. > > > Diffs > ----- > > ambari-web/app/messages.js 8861b2a > ambari-web/app/templates/main/service/item.hbs f61695e > ambari-web/app/views/common/quick_view_link_view.js c2f7dcc > ambari-web/test/views/common/quick_link_view_test.js 93a235c > > Diff: https://reviews.apache.org/r/43189/diff/ > > > Testing > ------- > > unit test > > manually patch a cluster and test the error message when oozie server is stopped. > > > Thanks, > > Di Li > > --===============7777551344155261974==--