ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-15198) Close icons on modal top right do not honor the underlying logic associated with the close/cancel buttons
Date Fri, 26 Feb 2016 15:43:18 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-15198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169211#comment-15169211
] 

Hudson commented on AMBARI-15198:
---------------------------------

FAILURE: Integrated in Ambari-trunk-Commit #4394 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4394/])
AMBARI-15198. Close icons on modal top right do not honor the underlying (pallav.kul: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=5fd757939cddaafa9f8426044ebee3c72f28c23c])
* contrib/views/files/src/main/resources/ui/app/templates/components/copy-modal.hbs
* contrib/views/files/src/main/resources/ui/app/templates/components/move-modal.hbs
* contrib/views/files/src/main/resources/ui/app/services/file-copy.js
* contrib/views/files/src/main/resources/ui/app/templates/components/delete-modal.hbs
* contrib/views/files/src/main/resources/ui/app/templates/components/upload-file.hbs
* contrib/views/files/src/main/resources/ui/app/templates/components/rename-modal.hbs
* contrib/views/files/src/main/resources/ui/app/templates/components/permission-modal.hbs
* contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs
* contrib/views/files/src/main/resources/ui/app/templates/components/new-directory.hbs
* contrib/views/files/src/main/resources/ui/app/services/file-move.js


> Close icons on modal top right do not honor the underlying logic associated with the
close/cancel buttons
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-15198
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15198
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-views
>    Affects Versions: 2.2.2
>            Reporter: Pallav Kulshreshtha
>            Assignee: Pallav Kulshreshtha
>             Fix For: 2.2.2
>
>         Attachments: AMBARI-15198_branch-2.2.patch
>
>
> The cross button (close/cancel) on the top right of each modal do not honor the logic
associated with the cancel/close button on the model.
> We should not use data-dismiss="modal" and use action to call the same action associated
with the close/cancel button.
> Also as part of code clean up, please remove unused services for copy and move feature.
These services have been moved in file Operations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message