ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-15198) Close icons on modal top right do not honor the underlying logic associated with the close/cancel buttons
Date Fri, 26 Feb 2016 11:17:18 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-15198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168834#comment-15168834
] 

Hadoop QA commented on AMBARI-15198:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12790081/AMBARI-15198_branch-2.2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in contrib/views/files.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/5582//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/5582//console

This message is automatically generated.

> Close icons on modal top right do not honor the underlying logic associated with the
close/cancel buttons
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-15198
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15198
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-views
>    Affects Versions: 2.2.2
>            Reporter: Pallav Kulshreshtha
>            Assignee: Pallav Kulshreshtha
>             Fix For: 2.2.2
>
>         Attachments: AMBARI-15198_branch-2.2.patch
>
>
> The cross button (close/cancel) on the top right of each modal do not honor the logic
associated with the cancel/close button on the model.
> We should not use data-dismiss="modal" and use action to call the same action associated
with the close/cancel button.
> Also as part of code clean up, please remove unused services for copy and move feature.
These services have been moved in file Operations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message