ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jun aoki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-14966) Stack Advisor incorrectly recommends Slave component on a host which does not have it installed during Add service wizard
Date Fri, 12 Feb 2016 01:02:18 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-14966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143818#comment-15143818
] 

jun aoki commented on AMBARI-14966:
-----------------------------------

Got 2 +1s in reviewboard. Committing .

> Stack Advisor incorrectly recommends Slave component on a host which does not have it
installed during Add service wizard
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-14966
>                 URL: https://issues.apache.org/jira/browse/AMBARI-14966
>             Project: Ambari
>          Issue Type: Bug
>          Components: stacks
>    Affects Versions: trunk
>            Reporter: bhuvnesh chaudhary
>            Assignee: bhuvnesh chaudhary
>            Priority: Minor
>             Fix For: trunk, 2.2.0
>
>         Attachments: AMBARI-14966-2.patch, AddHostWithoutAnyService.png, AfterFix.png,
FreshInstallOnSingleNode.png, IncorrectAssignment.png
>
>
> Steps to reproduce:
> - Install a cluster with HDFS (To start with single node host c6401)
> [^FreshInstallOnSingleNode.png]
> - Add a new host (c6402) and don't add any of the slave components or client
> [^AddHostWithoutAnyService.png]
> - Add HAWQ or any other service, don't change the recommendation on master components
page and click next
> - Datanode checkbox will be checked on c6402 even though its not installed.
> [^IncorrectAssignment.png]
> Bug:
> - Datanode should not be checked on c6402 as its not installed on the host. 
> Current Behavior:
> - In stack advisor, a list of free hosts is created at https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/stack_advisor.py#L382
> - During the step of creating the recommendation for Slave components slave hosts map
is extended with any of the hosts in the freeHosts list at https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/stack_advisor.py#L412-L413
> - Then in Ambari-web it updates the checkbox or datanode as installed on c6402.
> Since this minor code changes goes to core stack advisor, i am requesting inputs to be
sure before going ahead with the change.
> Few questions:
> 1. Do we extend the hostlist for already installed Slaves for some reason or its incorrect
?
> 2. Do you foresee any concerns with the patch. (I have tested it on Fresh Install of
Cluster and Add services page)
> After fix: Datanode is not checked  on c6402
> [^AfterFix.png]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message