ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun aoki <jun.aoki....@gmail.com>
Subject Re: Review Request 44119: Alerts for PXF component status
Date Mon, 29 Feb 2016 22:01:35 GMT


> On Feb. 27, 2016, 1 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
line 21
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line21>
> >
> >     I see other implementations used 
> >     ```
> >     from resource_management.core.logger import Logger
> >     ```
> >     Can we consider this for logging?

I followed this convention
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py#L35
Let me know if you have a strong preference for the change.


- jun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121028
-----------------------------------------------------------


On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
>     https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> -------
> 
> Manually tested. 
> 
> 
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
> 
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message