ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt <mithm...@gmail.com>
Subject Re: Review Request 44119: Alerts for PXF component status
Date Sat, 27 Feb 2016 01:11:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line
72)
<https://reviews.apache.org/r/44119/#comment182610>

    The log is common to all alerts which are run. It would be better to say which alert it
is, for making debugging easier in the future.
    
    logger.info("[Alert PXF API]: getting delegation token from {0}".format(url))
    
    Consider other logger messages as well.



ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line
150)
<https://reviews.apache.org/r/44119/#comment182617>

    The part of the message 'PXF is not functional' is already covered on Line 155. If you
don't want to repeat the same information, you may delete it.



ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line
157)
<https://reviews.apache.org/r/44119/#comment182619>

    Is there a case where the alert is CRITICAL?
    
    If PXF component which is on the same host as NAMENODE, would that be CRITICAL? Or PXF
service would still be operational as a whole relying on other PXF hostcomponents.


- Matt


On Feb. 26, 2016, 4:35 p.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 4:35 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
>     https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION

>   ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> -------
> 
> Manually tested. 
> 
> 
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
> 
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message