ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alejandro Fernandez <afernan...@hortonworks.com>
Subject Re: Review Request 44074: Authorization for Auto start services
Date Fri, 26 Feb 2016 19:28:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44074/#review120934
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
(line 623)
<https://reviews.apache.org/r/44074/#comment182463>

    Can we a description in Javadoc for this?


- Alejandro Fernandez


On Feb. 26, 2016, 4:05 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44074/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 4:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15190
>     https://issues.apache.org/jira/browse/AMBARI-15190
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We need to add authorization for Auto start services.
> 
> #Solution
> - Users with the ability to modify cluster configurations (`CLUSTER.MODIFY_CONFIGS`)
should be able to toggle the cluster-level auto start value.
> - Users with the ability to start and stop services (`SERVICE.START_STOP`) should be
able to toggle the service-level auto start value.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
0e97e1e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
c624cfd 
>   ambari-web/app/views/main/admin.js 8b9ec03 
>   ambari-web/app/views/main/menu.js b71bbd3 
> 
> Diff: https://reviews.apache.org/r/44074/diff/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message