ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nate Cole <nc...@hortonworks.com>
Subject Re: Review Request 44066: Add pre-upgrade check that warns about components with VERSION_MISMATCH
Date Fri, 26 Feb 2016 16:23:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44066/#review120876
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java (line
65)
<https://reviews.apache.org/r/44066/#comment182402>

    FailedOn should be a hostname.  The fail message should contain the detail.


- Nate Cole


On Feb. 26, 2016, 10:30 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44066/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 10:30 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-15203
>     https://issues.apache.org/jira/browse/AMBARI-15203
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add pre-upgrade check that warns about components with VERSION_MISMATCH
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa

>   ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
0be5be1 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44066/diff/
> 
> 
> Testing
> -------
> 
> Failed tests:
>   ComponentResourceProviderTest.testGetResourcesAsAdministrator:183->testGetResources:289
expected:<[tru]e> but was:<[fals]e>
>   ComponentResourceProviderTest.testGetResourcesAsClusterAdministrator:188->testGetResources:289
expected:<[tru]e> but was:<[fals]e>
>   ComponentResourceProviderTest.testGetResourcesAsServiceAdministrator:193->testGetResources:289
expected:<[tru]e> but was:<[fals]e>
>   AmbariLdapDataPopulatorTest.testSynchronizeExistingLdapGroups_removeDuringIteration:325
>   Expectation failure on verify:
>     AmbariLdapDataPopulatorTestInstance.getLdapGroupByMemberAttr("group2"): expected:
1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed »  Unexpected exception, expected<org.apac...
>   KerberosCheckerTest.testCheckPassed:62 » ClassCast class sun.security.provider...
> 
> Tests run: 3869, Failures: 4, Errors: 2, Skipped: 32
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [2.845s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.856s]
> [INFO] Ambari Server ..................................... FAILURE [1:34:28.716s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message