ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pallav Kulshreshtha <pallav....@gmail.com>
Subject Review Request 44059: Close icons on modal top right do not honor the underlying logic associated with the close/cancel buttons
Date Fri, 26 Feb 2016 07:01:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44059/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Jaimin Jetly, and Nitiraj Rathore.


Bugs: AMBARI-15198
    https://issues.apache.org/jira/browse/AMBARI-15198


Repository: ambari


Description
-------

- Removed data-dismiss attribute and added action 'close' so that it should be able to do
all the task for modal close under the hood. 
- Removed unused services for copy and move feature.


Diffs
-----

  contrib/views/files/src/main/resources/ui/app/services/file-copy.js 7193177 
  contrib/views/files/src/main/resources/ui/app/services/file-move.js 859f04c 
  contrib/views/files/src/main/resources/ui/app/templates/components/copy-modal.hbs 3e561e5

  contrib/views/files/src/main/resources/ui/app/templates/components/delete-modal.hbs 207a2a8

  contrib/views/files/src/main/resources/ui/app/templates/components/move-modal.hbs 1655930

  contrib/views/files/src/main/resources/ui/app/templates/components/new-directory.hbs bc21f31

  contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs
98a5459 
  contrib/views/files/src/main/resources/ui/app/templates/components/permission-modal.hbs
e6dee66 
  contrib/views/files/src/main/resources/ui/app/templates/components/rename-modal.hbs 8b1fca7

  contrib/views/files/src/main/resources/ui/app/templates/components/upload-file.hbs c1352dd


Diff: https://reviews.apache.org/r/44059/diff/


Testing
-------

Manual testing done.


Thanks,

Pallav Kulshreshtha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message