ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt <mithm...@gmail.com>
Subject Re: Review Request 43663: PXF Service checks fails with timeout
Date Mon, 22 Feb 2016 03:48:24 GMT


> On Feb. 21, 2016, 2:47 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py,
line 261
> > <https://reviews.apache.org/r/43663/diff/4/?file=1263592#file1263592line261>
> >
> >     Do you think we should call __cleanup_hbase_data before writing data?
> >     
> >     Seems like the old code was doing a cleanup before writing.
> 
> bhuvnesh chaudhary wrote:
>     it still disables and drop hbase table as part of populating data. didn't wanted
to have separate call to disable it, so kept as part of populating data.

Perfect


> On Feb. 21, 2016, 2:47 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py,
line 357
> > <https://reviews.apache.org/r/43663/diff/4/?file=1263592#file1263592line357>
> >
> >     Do you think we should call __cleanup_hive_data before writing data?
> >     
> >     Seems like the old code was doing a cleanup before writing.
> 
> bhuvnesh chaudhary wrote:
>     it still disables and drop hbase table as part of populating data. didn't wanted
to have separate call to disable it, so kept as part of populating data.

Perfect


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43663/#review120079
-----------------------------------------------------------


On Feb. 20, 2016, 6:19 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43663/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2016, 6:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksandr Diachenko,
Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15061
>     https://issues.apache.org/jira/browse/AMBARI-15061
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During PXF service check, in order to execute hbase / hive command, we do initialize
the shell everytime (hbase shell / hive) and then run the command. Initializing the shell
takes time and we do that around 3-4 times which consumes majority of the time.
> We should initialize the shell once, and execute the commands using a file instead of
doing individually.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
b3e85e4 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py
9d93a38 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
21b7c5d 
> 
> Diff: https://reviews.apache.org/r/43663/diff/
> 
> 
> Testing
> -------
> 
> yes. manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message