ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt <mithm...@gmail.com>
Subject Re: Review Request 43771: HAWQSEGMENT should be not be recommended on host which does not have DataNode
Date Sun, 21 Feb 2016 22:34:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43771/#review120078
-----------------------------------------------------------


Fix it, then Ship it!




The code and test case looks good. However, the comment does not align with the test case
that was added.


ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py (line 227)
<https://reviews.apache.org/r/43771/#comment181444>

    Thought the JIRA was about 'HAWQSEGMENT should not be recommended on a host without DATANODE'.
    
    I see no DATANODE on host-group-1, but the comment says HAWQSEGMENT should be recommended
on host-group-1? I believe you meant to say that the recommendation should have neither of
them on host-group-1.


- Matt


On Feb. 20, 2016, noon, bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43771/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2016, noon)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya,
Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15116
>     https://issues.apache.org/jira/browse/AMBARI-15116
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patches ensures that HAWQSEGMENT should not be recommended on host which does not
have DataNode at Assign Slaves and Client page.
> Recommendation should always suggests to have HAWQSEGMENT colocated with DATANODE.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 34e4cfa 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 03ae6cc 
> 
> Diff: https://reviews.apache.org/r/43771/diff/
> 
> 
> Testing
> -------
> 
> yes. manual
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message