ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexandr Antonenko <hiv...@gmail.com>
Subject Re: Review Request 43430: assign_master_component.js does not show recommendations while adding master component for a service which is already installed
Date Fri, 19 Feb 2016 18:57:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43430/#review119919
-----------------------------------------------------------




ambari-web/app/mixins/wizard/assign_master_components.js (line 764)
<https://reviews.apache.org/r/43430/#comment181319>

    Ember has mapProperty function, there is no need to use map in this case.



ambari-web/app/mixins/wizard/assign_master_components.js (line 770)
<https://reviews.apache.org/r/43430/#comment181320>

    The same here, please use mapProperty



ambari-web/app/mixins/wizard/assign_master_components.js (line 776)
<https://reviews.apache.org/r/43430/#comment181326>

    No need in such construction, there is native ember function pushObjects.


- Alexandr Antonenko


On Feb. 16, 2016, 10:13 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43430/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 10:13 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko,
Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton
Alex, Oleksandr Diachenko, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14987
>     https://issues.apache.org/jira/browse/AMBARI-14987
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On the assign masters page for the wizard, recommendations are not shown for a master
component that is being added for an installed service.
> 
> This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard
(situation: HAWQ service is already installed on the cluster).
> 
> The function getHostForMaster used to return the next available host for the master.
> For example:
> Case 1: component C1 is NOT installed on any hosts.
> getHostForMaster would return the first host from the allHosts list.
> Case 2: component C2 is installed on host H1
> getHostForMaster would return next available host from the allHosts list.
> If allHosts = ['H1', 'H2', 'H3']. It would return H2
> 
> To avoid just placing the component on the next available host, the recommendation is
considered.
> Current implementation:
> If a host is recommended for the master, place it on that host (if it is not already
installed on that host).
> If no recommendation is given, place it on the next available host.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 9d5cbc1 
>   ambari-web/app/mixins/wizard/assign_master_components.js f6d1b1a 
>   ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43430/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested.
> 
> Tested assign_master page on cluster installation, add service wizard, enable namenode
wizard and add hawq standby wizard.
> 
> Unit test added:
>   10412 tests complete (9 seconds)
>   121 tests pending
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 41.211 s
> [INFO] Finished at: 2016-02-16T14:12:45-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message