ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sebastian Toader <stoa...@hortonworks.com>
Subject Re: Review Request 42912: Clients names different on host details page and filter
Date Fri, 19 Feb 2016 11:11:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/#review119864
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On Feb. 19, 2016, 12:03 p.m., Daniel Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42912/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:03 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton,
Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14830
>     https://issues.apache.org/jira/browse/AMBARI-14830
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Clients names were different on host details page and filter for components Pig, Sqoop,
Slider, Mahout.
> Displayed names now come from metainfo.xml
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
c25c970 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
f7dd301 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
3ad6e64 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
a2a58e8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
7e1dd1d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
bfb6214 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70

>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35

>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1

>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml b5db91b

>   ambari-server/src/main/resources/properties.json 4052ad2 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
7643abb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
f38fab1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
f9c1fe4 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
c480156 
>   ambari-web/app/controllers/global/update_controller.js 04e7427 
>   ambari-web/app/mappers/components_state_mapper.js 0f2b627 
>   ambari-web/app/mappers/hosts_mapper.js 7691f2b 
>   ambari-web/app/models/client_component.js 816950c 
>   ambari-web/app/models/host_component.js a081d62 
> 
> Diff: https://reviews.apache.org/r/42912/diff/
> 
> 
> Testing
> -------
> 
> The existing unit tests are aligned to the modifications, but I did not find a way to
e2e test the fix.
> 
> 
> File Attachments
> ----------------
> 
> Branch 2.2.2
>   https://reviews.apache.org/media/uploaded/files/2016/02/19/37481770-3502-4d82-a2a9-453faf1bb477__AMBARI-14830_branch-2.2.2.patch
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message