ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun aoki <jun.aoki....@gmail.com>
Subject Re: Review Request 43644: Ambari should show no. of HAWQ segments live on main dashboard
Date Fri, 19 Feb 2016 01:16:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/#review119750
-----------------------------------------------------------




ambari-web/app/models/service/hawq.js (line 1)
<https://reviews.apache.org/r/43644/#comment181091>

    Is this required?



ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js (line 51)
<https://reviews.apache.org/r/43644/#comment181105>

    This may not be used as it is about started vs total?


- jun aoki


On Feb. 17, 2016, 7:57 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43644/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 7:57 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary,
Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-15060
>     https://issues.apache.org/jira/browse/AMBARI-15060
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The no. of HAWQ segments alive should be displayed as a widget on Ambari's main dashboard.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 25c3f43 
>   ambari-web/app/mappers/components_state_mapper.js 0f2b627 
>   ambari-web/app/messages.js a7e4ff3 
>   ambari-web/app/models.js b607bee 
>   ambari-web/app/models/service/hawq.js PRE-CREATION 
>   ambari-web/app/views.js 7e461f9 
>   ambari-web/app/views/main/dashboard/widgets.js b99d881 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/43644/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested. Images attached to JIRA.
> 
> Added additional unit test.
>   10416 tests complete (10 seconds)
>   121 tests pending
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 53.572 s
> [INFO] Finished at: 2016-02-17T11:55:29-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message