ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aravindan Vijayan <avija...@hortonworks.com>
Subject Re: Review Request 43739: AMBARI-15099 : Ambari missing metrics in UI with Vip settings enabled
Date Thu, 18 Feb 2016 21:26:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43739/#review119720
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
(line 311)
<https://reviews.apache.org/r/43739/#comment181064>

    clusterMetricCollectorMap is a data structure that tracks current collector. Removing
the logic to use the same data structure for Vip host.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
(line 353)
<https://reviews.apache.org/r/43739/#comment181065>

    Always honor Vip settings over the clusterMetricCollectorMap host.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java

<https://reviews.apache.org/r/43739/#comment181063>

    Removed dependency on vip configs here.


- Aravindan Vijayan


On Feb. 18, 2016, 9:23 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43739/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 9:23 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15099
>     https://issues.apache.org/jira/browse/AMBARI-15099
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM
> When using a vip settings for a cluster with 2 Collectors (1 active at a time), no metrics
are seen unless Ambari Server is restarted.
> 
> BUG
> In a cluster with metrics collector Vip settings enabled, when a Metrics Collector instance
status changes from STOPPED to STARTED, it is not tracked in the data structure that maintains
the collector host in Ambari Server. This causes the Ambari server to drop requests for metrics
assuming there is no Provider to satsify the request.
> 
> FIX
> Decouple the data structure used to track collector hosts and Vip host.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
5fb2cf0 
> 
> Diff: https://reviews.apache.org/r/43739/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message