ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Hurley <jhur...@hortonworks.com>
Subject Re: Review Request 43640: RU/EU can't start if hosts have name in MixedCASE in configs for NameNode, HBASE Master, ResourceManager
Date Thu, 18 Feb 2016 12:57:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43640/#review119607
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On Feb. 17, 2016, 2:25 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43640/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 2:25 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and
Nate Cole.
> 
> 
> Bugs: AMBARI-15064
>     https://issues.apache.org/jira/browse/AMBARI-15064
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> RU/EU tries to resolve the hostnames for NameNode, HBASE Master, and ResourceManager
by using MasterHostResolver.java, which queries configs and then JMX.
> 
> Ambari DB stores the hostnames in all lowercase, so if the configs or JMX store the hostnames
in a different case, then Ambari will throw an exception that the host could not be found.
> 
> To fix this, convert all hostnames to lowercase.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
795dfa7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
70440fc 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java
561350b 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java eb5bf62

> 
> Diff: https://reviews.apache.org/r/43640/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests in UpgradeHelperTest.java
> Verified that was able to start Express Upgrade.
> 
> Waiting for full set of unit tests to run.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message