ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe \(Joe\) Wang" <jw...@hortonworks.com>
Subject Re: Review Request 43670: AMBARI-15074 Combo Search: Implement "host" related filters
Date Wed, 17 Feb 2016 21:40:17 GMT


> On Feb. 17, 2016, 8:43 p.m., Richard Zang wrote:
> > Visualsearch related callbacks should be kept in VSCallbacks.

That's due to we are reusing current filter mechanism to work with host page updater. We will
refactor both of them in the future.


- Zhe (Joe)


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43670/#review119521
-----------------------------------------------------------


On Feb. 17, 2016, 7:33 p.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43670/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 7:33 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15074
>     https://issues.apache.org/jira/browse/AMBARI-15074
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Implement host related filters:
> Hostname (will be a filter substring match)
> IP Address (will be a filter substring match)
> Rack (will be a fixed list of choices, since this is a finite list for a given cluster)
> Service (will be a fixed list of choices, finds any host with any component related to
that service)
> Component (will be a fixed list of choices, should be grouped "category" by Service,
since this is a finite list of choices for a given cluster)
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/host.js a38b2db 
>   ambari-web/app/controllers/main/host/combo_search_box.js f4cc50f 
>   ambari-web/app/views/main/host/combo_search_box.js 0ab6029 
> 
> Diff: https://reviews.apache.org/r/43670/diff/
> 
> 
> Testing
> -------
> 
> Local ambari-web test passed.
> 24271 tests complete (22 seconds)
> 156 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message