ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aravindan Vijayan <avija...@hortonworks.com>
Subject Review Request 43627: AMBARI-15063 : Metrics monitor fails on restart
Date Tue, 16 Feb 2016 21:29:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43627/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-15063
    https://issues.apache.org/jira/browse/AMBARI-15063


Repository: ambari


Description
-------

PROBLEM
Metrics Monitor failed to START at install on 1 host. Restart also never worked.

BUG
Ambari metrics monitor startup script had a stale pid file with value as 327, and it used
"ps ax -o pid | grep <pid>" to check if a monitor process is already running. The above
check always returned true since there was another system process with process Id = 3327.
Hence, the script assumed that the metric monitor process was already running.

FIX
Change to use grep exact match (grep -w) while checking for process with process ID.


Diffs
-----

  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/ambari-metrics-monitor 815b3e4 
  ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector f83af50


Diff: https://reviews.apache.org/r/43627/diff/


Testing
-------

Manual testing done.


Thanks,

Aravindan Vijayan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message