ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver Szabo <osz...@hortonworks.com>
Subject Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is "Corrupted replica"
Date Tue, 16 Feb 2016 11:54:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/
-----------------------------------------------------------

(Updated Feb. 16, 2016, 11:54 a.m.)


Review request for Ambari, Daniel Gergely, Jaimin Jetly, Laszlo Puskas, and Yusaku Sako.


Bugs: AMBARI-12931
    https://issues.apache.org/jira/browse/AMBARI-12931


Repository: ambari


Description
-------

Problem:

- Corrupted Block metric on the UI means corrupted replicas. 

Solution:

- In fact this metric comes from hadoop: 
 
  FSNamesystem.java:
  
  @Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
  public long getCorruptReplicaBlocks() {
    return blockManager.getCorruptReplicaBlocksCount();
  }
- Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only
UI change, what clarifies the definition.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 2ea326a

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 1010128 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
608a348 
  ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5 
  ambari-web/app/messages.js 08ff073 

Diff: https://reviews.apache.org/r/38095/diff/


Testing (updated)
-------

Unit testing done.


Thanks,

Oliver Szabo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message