ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akhil PB <...@hortonworks.com>
Subject Re: Review Request 42712: AMBARI-14753: Capsched view: The view does not show the "effective" permissions of a queue
Date Sat, 13 Feb 2016 05:40:21 GMT


> On Feb. 13, 2016, 12:56 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js,
line 271
> > <https://reviews.apache.org/r/42712/diff/3/?file=1238374#file1238374line271>
> >
> >     Typo - 'permissn'

This is not typo, I shortened the variable name. Anyway I will correct it.


> On Feb. 13, 2016, 12:56 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js,
line 266
> > <https://reviews.apache.org/r/42712/diff/3/?file=1238374#file1238374line266>
> >
> >     Hash/Object would have been a better option for users & groups.

Users and groups arrays are list of users and groups who can administer queue or submit applications
respectively.
So why do we need hash here? 
It seems simple list would be enough, right?


- Akhil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42712/#review118985
-----------------------------------------------------------


On Feb. 9, 2016, 11:58 a.m., Akhil PB wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42712/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-14753
>     https://issues.apache.org/jira/browse/AMBARI-14753
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added effective permissions for acl_submit_application and acl_administer_queue in capshed.
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473

>   contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
c0acf4f 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1

> 
> Diff: https://reviews.apache.org/r/42712/diff/
> 
> 
> Testing
> -------
> 
> Done some manual unit testing in both ambari operator and non-operator mode.
> 
> 
> Thanks,
> 
> Akhil PB
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message