ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe \(Joe\) Wang" <jw...@hortonworks.com>
Subject Review Request 43551: AMBARI-15038 Alert definitions: Percentage params get validation errors when they shouldn't
Date Sat, 13 Feb 2016 00:20:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43551/
-----------------------------------------------------------

Review request for Ambari, Richard Zang, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-15038
    https://issues.apache.org/jira/browse/AMBARI-15038


Repository: ambari


Description
-------

In alert definitions, percentage params (e.g. NameNode RPC Latency (Daily) --> standard
deviation threshold) get validation errors when their values are above 100, which could be
a valid value.
Resolution is removing the restriction of value has to be less than 100.


Diffs
-----

  ambari-web/app/models/alerts/alert_config.js c86b19a 
  ambari-web/test/models/alerts/alert_config_test.js 4b788f8 

Diff: https://reviews.apache.org/r/43551/diff/


Testing
-------

Modified unit test. Local ambari-web test passed.
24292 tests complete (21 seconds)
156 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message