ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe \(Joe\) Wang" <jw...@hortonworks.com>
Subject Review Request 42627: AMBARI-15037 When saving a SCRIPT edit, it loses the script path
Date Fri, 12 Feb 2016 23:13:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42627/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, Richard Zang, Srimanth Gunturi, and Yusaku Sako.


Summary (updated)
-----------------

AMBARI-15037 When saving a SCRIPT edit, it loses the script path


Bugs: AMBARI-15037
    https://issues.apache.org/jira/browse/AMBARI-15037


Repository: ambari


Description (updated)
-------

For script alerts, after editing in the UI and saving the change, it loses the "path".
Resolution is to add the whole source data instead of only the parameters


Diffs (updated)
-----

  ambari-web/app/controllers/main/alerts/definition_configs_controller.js ec5680c 
  ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js c957efd 

Diff: https://reviews.apache.org/r/42627/diff/


Testing (updated)
-------

Modified unit test. Local ambari-web test passed.
24292 tests complete (21 seconds)
156 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message